Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix COMPOSER_PATH may be false #8315

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 9, 2023

Description
Supersedes #8314

COMPOSER_PATH may be false.

PHP Fatal error:  Uncaught TypeError: is_file(): Argument #1 ($filename) must be of type string, bool given in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Autoloader/Autoloader.php:126

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7148219475/job/19469003051

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Dec 9, 2023
PHP Fatal error:  Uncaught TypeError: is_file(): Argument #1 ($filename) must be of type string, bool given in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Autoloader/Autoloader.php:126
@kenjis kenjis force-pushed the fix-test-bootstrap.php branch from f354c85 to b17dbf5 Compare December 9, 2023 08:46
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Dec 9, 2023
@kenjis
Copy link
Member Author

kenjis commented Dec 9, 2023

This PR will fix GitHub Action check fails in 4.5.

@kenjis kenjis merged commit ba8c285 into codeigniter4:develop Dec 9, 2023
61 checks passed
@kenjis kenjis deleted the fix-test-bootstrap.php branch December 9, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants